deps: libp2p:bump libp2p version to v0.30 #11434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -43,7 +43,7 @@ func (bbr BadBlockReason) String() string { | |||
| } | |||
|
|
|||
| func NewBadBlockCache() *BadBlockCache { | |||
| cache, err := lru.NewARC[cid.Cid, BadBlockReason](build.BadBlockCacheSize) | |||
| cache, err := arc.NewARC[cid.Cid, BadBlockReason](build.BadBlockCacheSize) | |||
There was a problem hiding this comment.
We don't really need this for the libp2p upgrade, right ? Do you think we can do this in a separate PR ?
There was a problem hiding this comment.
This is cherry-picked from master, probably best to leave it as-is.
There was a problem hiding this comment.
Yes you need this, due to a breaking change in that library introduced in a patch release (see hashicorp/golang-lru#142). I agree that this cherry-pick should be left as is.
Stebalien
force-pushed
the
jen/makemarteenhappy
branch
from
e68cda5 to
b78f9ce
Compare
|
Ok, so, we're simply not downloading the params in those cases. So... I'm backporting a small change to the unit tests to see if it matters. Otherwise... I'm not sure. |
|
Ok, now both cases should be fixed. |
Stebalien
force-pushed
the
jen/makemarteenhappy
branch
from
464514b to
94787a6
Compare
Stebalien
force-pushed
the
jen/makemarteenhappy
branch
from
94787a6 to
c273cbd
Compare
|
@jennijuju Can we go ahead and merge this ? |
aarshkshah1992
approved these changes
Nov 22, 2023
marten-seemann
approved these changes
Nov 22, 2023
|
thank you all! |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libp2p v.0.30 has been integrated in lotus and tested with v1.25.0 train for over a month.
Bringing the libp2p dependency more up to date so that the one in the mandatory release doesn't fall behind too much.